make ItemSliceSync::get_mut() check that the index is in range #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some of the unsafety from ItemSliceSync::get_mut(). There's still the unsafety that the caller needs to make sure a single index is not used concurrently.
martinvonz
force-pushed
the
push-muuvrzoxkutp
branch
from
28dfe78 to
def27ae
Compare
By now we are certain the used indices are in bounds, but if they are not this would not be detected by the test-suite first.
|
Thanks a lot! Since this is an internal usage at some point the code has to 'trust itself' to indeed be correct. However, I have left the added check for use with debug assertions compiled in, so if there was a bug related to slice access now or in future it would be caught by this addition. |
|
Sorry, I forgot to push my local merge earlier and now had to rebase to get it in. GH doesn't detect that, thus I have to close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the unsafety from
ItemSliceSync::get_mut(). There's still the unsafety that the caller needs to make sure a single index is not used concurrently.