-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gix-config-value fuzzer #1225
Merged
Byron
merged 3 commits into
GitoxideLabs:main
from
nathaniel-brough:fuzz-gix-config-value
Jan 1, 2024
Merged
Add gix-config-value fuzzer #1225
Byron
merged 3 commits into
GitoxideLabs:main
from
nathaniel-brough:fuzz-gix-config-value
Jan 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nathaniel-brough
commented
Dec 31, 2023
- Add fuzzer
- Add associated dict
- Add fuzzer - Add associated dict
This one trigger's a bug. Repro
Stack trace
|
…values. Previously it would try to byte-index a presumed ascii string to convert hex to RGB, which could panic if the string wasn't actually ascii. Now it validates that the characters to convert are actually on a character boundary.
Thanks again for all your work and for relentlessly improving fuzzerage (coverage of the fuzzer :)). It's great it finds all the spots where strings are treated incorrectly as ASCII, I'd hope that this was it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.