Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gix-commitgraph::File fuzzer #1208

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Add gix-commitgraph::File fuzzer #1208

merged 3 commits into from
Dec 24, 2023

Conversation

nathaniel-brough
Copy link
Contributor

No description provided.

Byron
Byron approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for increasing coverage!

I took a look to see if one could avoid the tempfile, and it seems like it's possible to use an anonymous mapping which could be provided using an alternative contructor. I will give that a shot and merge when it works.

Byron added 2 commits December 24, 2023 10:20
@Byron
feat: TryFrom<MMap> for File to allow more arbitrary inputs.
8613c41 
This is particularly useful for fuzzing, but can certainly be interesting
for other low-level applications as well.
@Byron
Let commitgraph fuzzer use the latest API
672294e 
This increases performance by 4x while reducing kernel load to not being
present at all, down from 90%/nearly 1 CPU.
@Byron Byron force-pushed the fuzz-gix-commitgraph branch from 10c82e2 to 672294e Compare December 24, 2023 09:20
@Byron Byron merged commit 7e2add3 into GitoxideLabs:main Dec 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathaniel-brough @Byron