Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the CI fuzzer more time #1206

Conversation

nathaniel-brough
Copy link
Contributor

Currently the CI fuzzer isn't on the critical path to completion. So we can extend the amount of fuzzing time without impacting the critical path.

Currently the CI fuzzer isn't on the critical path to completion.
So we can extend the amount of fuzzing time without impacting the
critical path.
@nathaniel-brough
Copy link
Contributor Author

For context the "ci / test (pull_request)" seems to be the critical path.

@nathaniel-brough
Copy link
Contributor Author

Ah, it looks like I increased the time too much. I'll drop 40s off this tomorrow.

@Byron
Copy link
Member

Byron commented Dec 23, 2023

Thanks for the proposition. However, seeing the fuzzing stage to now dominate the runtime, I'd like to not pursue even if the runtime was reduced by a minute.

Instead, I'd like to see the current difference between CI-test and CI-fuzz as safety-buffer. The reason for not wanting to maximise fuzz time is the unpredictability of CI runtimes in general, while experience shows that the fuzzer finds obvious errors even within a very short time, while taking much longer than the time we have for follow-ups.

Thanks for your understanding.

@Byron Byron closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants