Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell-avoidance on windows #1117

Merged
merged 3 commits into from
Nov 16, 2023
Merged

shell-avoidance on windows #1117

merged 3 commits into from
Nov 16, 2023

Conversation

Byron
Copy link
Member

@Byron Byron commented Nov 16, 2023

This should help to allow windows users to use more complex programs,
which might not have been possible previously.

It also allows certain areas of gix to indicate that they are safe to
use with this flag, which always is the case when git is prefixed, like
with credential helpers.

@Byron
Copy link
Member Author

Byron commented Nov 16, 2023

@jalil-salame Today I finally found a way to achieve the same (or similar) program launch behaviour on windows as git, which doesn't use an intermediate shell there from what I can tell. This will help with any program invocation performed through gitoxide, like worktree-filters and diff-converters, on windows.

Previously this was a special case, albeit platform-independent, for credential helpers only.

gix-command/src/lib.rs Outdated Show resolved Hide resolved
@jalil-salame
Copy link
Contributor

That's great! Thank you! 🎉

This flag is enabled on windows by default to emulate `git` which
doesn't actually use a shell at all there.

This should help to allow windows users to use more complex programs,
which might not have been possible previously.

It also allows certain areas of `gix` to indicate that they are safe to
use with this flag, which always is the case when `git` is prefixed, like
with credential helpers.
@Byron Byron force-pushed the sh-on-windows branch 2 times, most recently from 3564f1d to b78950d Compare November 16, 2023 15:29
@Byron Byron merged commit 2b80d84 into main Nov 16, 2023
18 checks passed
@Byron Byron deleted the sh-on-windows branch November 16, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants