Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tree parsing #1102

Merged
merged 4 commits into from
Nov 10, 2023
Merged

fix tree parsing #1102

merged 4 commits into from
Nov 10, 2023

Conversation

Byron
Copy link
Member

@Byron Byron commented Nov 10, 2023

Related to #1096

Tasks

  • fix CI (hopefully after reproducing it).
  • keep 'raw' mode to maintain round-tripping during decoding/encoding and fsck

This failure happens on CI as the "0" is missing there, and it's
not reproducing anywhere else. Probably related to the HTTP client
doing something differently there for some reason.

Let's not be bothred by it by simply removing it from the expectation.
… the new `EntryKind`.

Please note that `EntryKind` and `EntryMode` can be converted from and to each other.
@Byron Byron merged commit ff99a18 into main Nov 10, 2023
18 checks passed
@Byron Byron deleted the fix-1096 branch November 10, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant