Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
re-enable running git-daemon tests on CI
Browse files Browse the repository at this point in the history
It became clear that the issue was home-made. The remote interactions of
the 'free' variants never terminated the connection, which could have left
the daemon hanging.

It might have filled up its 32 slots, leading to rejection later, maybe.
Byron committed Dec 20, 2024
1 parent aba9c17 commit feaadb3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/journey/gix.sh
Original file line number Diff line number Diff line change
@@ -109,7 +109,7 @@ title "gix (with repository)"

# for some reason, on CI the daemon always shuts down before we can connect,
# or isn't actually ready despite having accepted the first connection already.
(not_on_ci with "git:// protocol"
(with "git:// protocol"
launch-git-daemon
(with "version 1"
it "generates the correct output" && {
@@ -278,7 +278,7 @@ title "gix commit-graph"
)
)
fi
(not_on_ci with "git:// protocol"
(with "git:// protocol"
launch-git-daemon
(with "version 1"
(with "NO output directory"

0 comments on commit feaadb3

Please sign in to comment.