Skip to content

Commit

Permalink
Rename nonexistent repo in Makefile from foo to nonexistent
Browse files Browse the repository at this point in the history
The nonexistent repo used to get data from a 401 response in the
`update-curl-fixtures` rule was formerly called `foo`. (In 1ea08bf
in #1624, I had erroneously said this was for a 404 response, but
the `foo` URL is the 401 URL, not the 404 URL.) This commit renames
it to `nonexistent`, which is more self-documenting and less likely
to be created by accident, even temporarily.

In 1ea08bf (#1624), it was changed from `Byron/foo` to
`GitoxideLabs/foo`, going along with the change of the existing
repository (gitoxide's own) from `Byron/gitoxide` to
`GitoxideLabs/gitoxide`. But while `Byron/foo` would continue not
to exist as long as the convention of not having a `foo` repo was
maintained by `@Byron`, a `foo` repository in `GitoxideLabs` might
someday be created by another developer who is not aware of its
status in `Makefile`. Renaming it to `nonexistent` should make this
easier to avoid.

I tested this change with the same approach as noted for 1ea08bf.
  • Loading branch information
EliahKagan committed Oct 14, 2024
1 parent 991c939 commit baa6f23
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ base_url = https://github.com/GitoxideLabs/gitoxide.git
update-curl-fixtures: ## use curl to fetch raw fixtures for use in unit test. Changes there might break them
curl -D - -L "$(base_url)/info/refs?service=git-upload-pack" > $(transport_fixtures)/v1/http-handshake.response
curl -D - -H 'Git-Protocol: version=2' -L "$(base_url)/info/refs?service=git-upload-pack" > $(transport_fixtures)/v2/http-handshake.response
curl -H 'User-Agent: git/oxide-0.1.0' -D - -H 'Git-Protocol: version=1' -L "https://github.com/GitoxideLabs/foo/info/refs?service=git-upload-pack" > $(transport_fixtures)/http-401.response
curl -H 'User-Agent: git/oxide-0.1.0' -D - -H 'Git-Protocol: version=1' -L "https://github.com/GitoxideLabs/nonexistent/info/refs?service=git-upload-pack" > $(transport_fixtures)/http-401.response
curl -D - -H 'Git-Protocol: version=1' -L "https://github.com/GitoxideLabs/gitoxide/info/refs?service=git-upload-pack" > $(transport_fixtures)/http-404.response

update-assets: $(baseline_asset_fixture) ## refresh assets compiled into the binaries from their source
Expand Down

0 comments on commit baa6f23

Please sign in to comment.