Skip to content

Commit

Permalink
Some TODOs to not forget where to continue (#298)
Browse files Browse the repository at this point in the history
  • Loading branch information
Byron committed Apr 4, 2022
1 parent 27df580 commit 84c0f15
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions git-revision/src/describe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ pub(crate) mod function {
let mut queue = VecDeque::from_iter(Some(commit.to_owned()));
let mut candidates = Vec::new();
let mut seen_commits = 0;
// TODO: actually use this
let mut _gave_up_on_commit = None;
let mut seen = hash_hasher::HashedMap::default();
seen.insert(commit.to_owned(), 0u32);
Expand Down Expand Up @@ -172,6 +173,8 @@ pub(crate) mod function {
}
}

// TODO: something like finish_computation() - testing that might be possible when setting max-candidates to 1

if candidates.is_empty() {
return Ok(None);
}
Expand Down

0 comments on commit 84c0f15

Please sign in to comment.