[Type] Can rename py dataclass structs when calling sub functions - #333
Closed
hughperkins wants to merge 90 commits into
Closed
hughperkins wants to merge 90 commits into
hughperkins wants to merge 90 commits into
Conversation
…o _kernel_types.py
…cluding the func used params yet
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:05 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:05 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:05 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:05 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
temporarily deployed
to
publish_pypi
December 27, 2025 17:20 — with
GitHub Actions
Inactive
hughperkins
commented
Dec 27, 2025
hughperkins
commented
Dec 28, 2025
Contributor
|
Collaborator
Author
Addressed both these points. |
erizmr
approved these changes
Jan 5, 2026
hughperkins
enabled auto-merge (squash)
January 5, 2026 13:46
hughperkins
disabled auto-merge
January 5, 2026 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
Key concept is that we need to store, during compilation:
We do this in the new pruning.py file, with each dict indexed first by func_id, which is unique per function.
We assume that the parameters used for a func are consistent across all calls to that func within the same compiled kernel. However, different calls to the same kernel can have different used parameters for each func in that kernel call, compared to other calls into the same kernel.
We only need to store the used parameters during the compilation of the kernel. Once the kernel is compiled, we throw away the function-specific lists of parameters - by discarding the ASTTransformer*Context objects - and store only the parametesr needed on entry to the top level kernel. We store these parameters in the Kernel object, indexed by calling key.
Old arch:
New arch:
copilot:summary
Walkthrough
copilot:walkthrough