[Bug] Fix ndarray memory leak#278
Merged
hughperkins merged 15 commits intomainfrom Nov 20, 2025
Merged
Conversation
duburcqa
approved these changes
Nov 17, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak in ndarray objects by moving the __del__ method from the ScalarNdarray class to the base Ndarray class, ensuring that all ndarray types (scalar, vector, and matrix) properly clean up their underlying C++ objects when garbage collected.
Key Changes
- Moved
__del__method fromScalarNdarraytoNdarraybase class to ensure all ndarray subclasses benefit from proper cleanup - Added test case to verify that ndarray deletion properly cleans up the underlying C++ object
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| python/gstaichi/lang/_ndarray.py | Moved __del__ from ScalarNdarray (removed lines 279-284) to Ndarray base class (added lines 41-45), ensuring VectorNdarray and MatrixNdarray also have proper cleanup |
| tests/python/test_ndarray.py | Added test_ndarray_del to verify that the C++ ndarray object is properly deleted when the Python wrapper goes out of scope |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+42
to
+46
| if impl is not None and impl.get_runtime is not None and impl.get_runtime() is not None: | ||
| prog = impl.get_runtime()._prog | ||
| if prog is not None: | ||
| prog.delete_ndarray(self.arr) | ||
|
|
There was a problem hiding this comment.
Overly complex 'del' method.
Suggested change
| if impl is not None and impl.get_runtime is not None and impl.get_runtime() is not None: | |
| prog = impl.get_runtime()._prog | |
| if prog is not None: | |
| prog.delete_ndarray(self.arr) | |
| pass | |
| def release(self): | |
| if impl is not None and impl.get_runtime is not None and impl.get_runtime() is not None: | |
| prog = impl.get_runtime()._prog | |
| if prog is not None: | |
| prog.delete_ndarray(self.arr) |
YilingQiao
approved these changes
Nov 17, 2025
duburcqa
reviewed
Nov 17, 2025
duburcqa
reviewed
Nov 17, 2025
…gstaichi into hp/ndarray-mem-leak
…gstaichi into hp/ndarray-mem-leak
duburcqa
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
See taichi-dev/taichi#8764 by @BernardoCovas for more details.
copilot:summary
Walkthrough
copilot:walkthrough