Skip to content

CI: Add more permissions to the Greetings workflow to fix the resource issue #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 3 commits into from
Nov 4, 2025
Merged

CI: Add more permissions to the Greetings workflow to fix the resource issue #4181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35aa74c
CI: Add more permissions to the Greetings workflow to fix the resourc…
seisman Oct 31, 2025
aae7d87
Only run in issues and PRs from forks
seisman Nov 2, 2025
7f8c0c3
Merge branch 'main' into ci/fix-welcome
seisman Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/welcome.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Greet first-time contributors.
#
# It runs in issues and pull requests from forks.

name: Greet First-Time Contributors

Expand All @@ -13,10 +15,13 @@ on:
permissions:
issues: write
pull-requests: write
id-token: write
contents: read

jobs:
greeting:
Copy link
Member

@weiji14 weiji14 Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an if-condition to only run this on forks? First time contributors usually won't run on 'GenericMappingTools/pygmt' unless they're a bot or something.

Copy link
Member Author

@seisman seisman Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In aae7d87, I've added the if-condition

if: github.event_name == 'issues' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository)

name: Greet First-Time Contributors
if: github.event_name == 'issues' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository)
runs-on: ubuntu-latest

steps:
Expand Down