Open
Conversation
This is a temporary fix to a problem where importing this particu lar module raised an error that max(vers) was empty because the f ile directory and file names are all hardcoded. A future JOANNE u pdate should fix this with paths not being part of src file, but rather a separate config file. But this particular change does no t need the aforementioned changes in how paths are provided. TLDR: L3 directory should contain only one L3 file; more than one will throw an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requirement of searching for the latest version of L3 files previously made it difficult to import
joanne.Level_4.ready_ds_for_regressionas a module, because the directories for L3 were hard-coded. To fix this, this requirement was removed with the assumption (or the demand) that the user provide only one L3 file in the directory.A subsequent function also called the
get_level3_datasetfunction as default for the L3 directory. This default value has also been removed so as to not mess up the functioning of the module.All these fixes should eventually become irrelevant with the introduction of a config file which would provide paths, rather than the hardcoded paths in the src files themselves.
This PR is currently kept open as a potential way to include the solutions for providing paths too... (But I don't have the time to fix them now, so this is kept for a later revisit)