Skip to content

Resolves: 959, 945, 953, 909 #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougse wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Resolves: 959, 945, 953, 909 #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9967df
Resolves
Aug 17, 2020
ff9a1f2
Merge branch 'master' into master
Gbuomprisco Oct 11, 2020
b080001
Merge branch 'master' into master
Gbuomprisco Oct 15, 2020
0ad0cd0
Merge branch 'master' into master
Gbuomprisco Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions modules/components/tag-input-form/tag-input-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,18 @@ export class TagInputForm implements OnInit, OnChanges {
return this.item.value;
}

private _inputText: string;

/**
* @name inputText
* @param text {string}
*/
public set inputText(text: string) {
this.item.setValue(text);

this.inputTextChange.emit(text);
if ( this._inputText != text ) {
this._inputText = text;
this.item.setValue(text);
this.inputTextChange.emit(text);
}
}

private readonly item: FormControl = new FormControl({ value: '', disabled: this.disabled });
Expand Down Expand Up @@ -194,7 +198,6 @@ export class TagInputForm implements OnInit, OnChanges {
* @param $event
*/
public onKeyDown($event) {
this.inputText = this.value.value;
if ($event.key === 'Enter') {
this.submit($event);
} else {
Expand All @@ -217,5 +220,6 @@ export class TagInputForm implements OnInit, OnChanges {
public submit($event: any): void {
$event.preventDefault();
this.onSubmit.emit($event);
this.form.reset();
}
}
2 changes: 1 addition & 1 deletion modules/components/tag-input/tag-input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ export class TagInputComponent extends TagInputAccessor implements OnInit, After
* @name hasErrors
*/
public hasErrors(): boolean {
return !!this.inputForm && this.inputForm.hasErrors();
return !!this.inputForm && !!this.inputForm.hasErrors();
}

/**
Expand Down