[pull] main from ultraworkers:main#1
Open
pull[bot] wants to merge 1532 commits into
Open
Conversation
code-yeongyu
force-pushed
the
main
branch
2 times, most recently
from
8cadf36 to
0e12d15
Compare
…nknown fallback
…enai_compat, trident, config, tools)
…kind, denied_tools initializer errors - Remove retry_after: None from ApiError::Api structs in openai_compat.rs (field was removed) - Remove SlashCommand::Team parse arm (variant was removed from enum) - Add config_load_error_kind: None to doctor path StatusContext initializer - Add Thinking arm to all ContentBlock match blocks in trident.rs - Remove cargo fmt drift across commands, config, compact, tools, trident
… .git writability opacity
…refs, fix parse_local_help_action return type
…izers; remove stale retry_after refs again
… bypass on Linux)
…ons, delete_session, session_exists) Adds session_store_lifecycle_regression_160 test that verifies the full SessionStore CRUD lifecycle. Also fixes pre-existing non-exhaustive match errors in trident.rs for the ContentBlock::Thinking variant.
… exit 1 - Add unsupported skills action guard in parse_args for remove/add/uninstall/delete - Add unsupported_skills_action to classify_error_kind for structured JSON errors - Fix pre-existing compile errors (stale retry_after field, missing Team variant) - Add regression test unsupported_skills_actions_return_typed_error_683
…help_action ? operator
…cycle fix(#160): add regression test for SessionStore lifecycle
…-action fix(#683): claw skills remove/add/uninstall/delete emits typed error, exit 1
Add Qwen model token limits for DashScope compatibility
Add SUPPRESS_CONFIG_WARNINGS_STDERR AtomicBool flag in runtime/config.rs and expose suppress_config_warnings_for_json_mode() via runtime crate. In main.rs, scan raw argv for --output-format json before parse_args and activate the flag so no settings-load warnings reach stderr on any JSON-mode surface (status, sandbox, system-prompt, mcp list, skills list, agents list, --resume /config*, etc.). Text-mode surfaces are unaffected; prose deprecation warnings continue to appear on stderr. All 572+ tests pass (one pre-existing worker_boot failure unrelated).
…f missing_credentials (#825) When looks_like_subcommand_typo fires on a single word with no close fuzzy matches, the fallthrough reached CliAction::Prompt → provider startup → misleading missing_credentials error. Fix: always return Err with command_not_found: prefix from the typo guard (with or without suggestions). Added command_not_found classifier arm in classify_error_kind. Unified existing unknown_subcommand kind under command_not_found in #825. Three new regression tests in output_format_contract.rs: - unknown_subcommand_json_emits_command_not_found - unknown_subcommand_text_emits_command_not_found_on_stderr - unknown_subcommand_typo_with_suggestions_json_emits_command_not_found Updated pre-existing unit test assertion (starts_with → contains) and classifier unit test (unknown_subcommand → command_not_found). 572 tests pass, 1 pre-existing worker_boot failure unrelated.
…ssing_credentials
Single-word all-alpha/dash tokens that don't match any known subcommand now always emit command_not_found (with or without fuzzy suggestions). Multi-word cases fall through to CliAction::Prompt (natural language prompt passthrough like 'claw explain this' must still work). The multi-word gap is documented as ROADMAP #826 (known limitation). Tests: - unknown_subcommand_json_emits_command_not_found (new) - unknown_subcommand_text_emits_command_not_found_on_stderr (new) - unknown_subcommand_typo_with_suggestions_json_emits_command_not_found (new) - multi_word_unknown_subcommand_falls_through_to_prompt_826 (documents gap) 572 tests pass, 1 pre-existing worker_boot failure unrelated.
Both direct-slash CLI path (claw /boguscommand) and resume slash path (claw --resume session /boguscommand) previously emitted error_kind:unknown (opaque fallback). Machine consumers could not distinguish unrecognized slash commands from other error classes. Fix: - format_unknown_direct_slash_command: prefix with 'unknown_slash_command:' - format_unknown_slash_command (resume path): prefix with 'unknown_slash_command:' - Add classifier arm for 'unknown_slash_command:' prefix One new regression test: direct_unknown_slash_command_emits_typed_error_kind Uses the direct-slash CLI path (no session load needed; reproducible on CI). 572 tests pass, 1 pre-existing worker_boot failure unrelated.
…#828) /approve, /yes, /deny, /no (and /y, /n) are valid REPL-only slash commands. Outside the REPL they were falling through to format_unknown_direct_slash_command -> error_kind:unknown_slash_command. Fix: intercept them in the SlashCommand::Unknown arm and emit interactive_only: prefix so classify_error_kind returns the correct kind. One new test: approve_deny_outside_repl_emits_interactive_only (covers /approve, /yes, /deny, /no) 572 tests pass, 1 pre-existing worker_boot failure unrelated.
…me for non-resume-safe commands
#829) Commands like /commit, /pr, /issue, /bughunter, /ultraplan are interactive-only and NOT resume-safe. Previously the generic interactive_only error always suggested 'claw --resume SESSION.jsonl /commit', which would just re-trigger interactive_only. Fix: check commands::resume_supported_slash_commands() in the SlashCommand::Ok(Some(cmd)) arm. Resume-safe commands get the full --resume suggestion; non-resume-safe commands only say 'Start claw'. Also update two existing unit tests whose assertions checked for the old 'interactive-only' substring (now 'interactive_only:' prefix). Two new integration tests: - non_resume_safe_interactive_only_hint_omits_resume_suggestion - resume_safe_interactive_only_hint_includes_resume_suggestion 572 tests pass, 1 pre-existing worker_boot failure unrelated.
…tion instead of missing_argument
Apply the bounded clippy pedantic cleanup from PR #3009.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )