Merge pull request #91 from GavinJoyce/gj/tag-name-is-component

create a `tag-name-is-component` helper
GavinJoyce · Oct 3, 2021 · badcac8 · badcac8
2 parents 8dbdcaf + 4885599
commit badcac8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/addon/components/menu/item-element.hbs b/addon/components/menu/item-element.hbs
@@ -1,5 +1,5 @@
 {{#let
-  (if this.tagNameIsComponent @tagName (element (or @tagName 'a')))
+  (if (tag-name-is-component @tagName) @tagName (element (or @tagName 'a')))
   as |Tag|
 }}
   <Tag

diff --git a/addon/components/menu/item-element.js b/addon/components/menu/item-element.js
diff --git a/addon/helpers/tag-name-is-component.js b/addon/helpers/tag-name-is-component.js
@@ -0,0 +1,7 @@
+import { helper } from '@ember/component/helper';
+
+function tagNameIsComponent([as]) {
+  return typeof as === 'object';
+}
+
+export default helper(tagNameIsComponent);
diff --git a/app/helpers/tag-name-is-component.js b/app/helpers/tag-name-is-component.js
@@ -0,0 +1 @@
+export { default } from 'ember-headlessui/helpers/tag-name-is-component';
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export { default } from 'ember-headlessui/helpers/tag-name-is-component';