More 1.21.9 Feature Updates #1168
Conversation
- This data field was removed in 1.21.5
gm4_metallurgy/since_88/data/gm4_metallurgy/function/init.mcfunction
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
- Disassemblers was left as `since_88` as the contents are generated - Standard Crafting was left as `since_88` because inverting it is not easy without errors in prior versions
Metallurgy Expansions - Update `modeldata_registry` with copper
This comment was marked as outdated.
This comment was marked as outdated.
| execute store result score $tool_max_damage gm4_ml_data run data get storage gm4_audere_shamir:temp/player/tool SelectedItem.components."minecraft:custom_data".MaxDurability | ||
| # | MaxDamage is set by gm4_moneo_shamir:store_maximum |
There was a problem hiding this comment.
Does this mean Audere is now reliant on Moneo? While that's technically fine while Moneo is in base Metallurgy it might cause problems if Moneo is ever updated / removed since it's unlikely this would be thought of then
There was a problem hiding this comment.
Yes, although this is a change from #1167 which is only mixed in here because I needed to handle overlays of the same files for copper tools. We can definitely move the store_maximum function into the metallurgy namespace if needed though
| execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch | ||
|
|
||
| # place block sound | ||
| playsound minecraft:block.wood.place block @a[distance=..15] |
There was a problem hiding this comment.
Also for the other materials, but I feel like this shouldn't play if the torch didn't actually place
There was a problem hiding this comment.
Oh huh, yeah. Likely a change for a different PR though so I'll make an issue to track it
3 participants
This PR
CanDuplicatenbt field from Gemini Shamir, this field was removed in MC 1.21.5#gm4:bootswith#minecraft:foot_armorbackport_81since_88contents are generated) and Standard Crafting