Reeling Rods - Module

[runcows]

Reeling Rods

A module that expands the capabilities of all fishing rods, as well as adding 2 new fishing rod enchantments (Reeling and Barbed) which are mutually exclusive.

These are the first GM4 custom enchantments using the vanilla system; they are intentionally not metallurgy shamirs.

All Rods

Added the following capabilities to all fishing rods:

• Pull Paintings off walls *
• Steal first the item from an item frame, and then pull the item frame off the wall *
• Snatch leashed mobs from leash knots *
• Pull shulkers towards you *
• Try and fail to pull in an end crystal (it explodes) *
• Dismount the pulled mob from what they're riding (Bedrock Parity)

* These entities can be hooked with a fishing rod, but in vanilla the only thing that happens is durability gets used.

Reeling

Reeling is an enchantment that revolves around stealing or yoinking certain items from entities.
These interactions are locked behind an enchantment either for balance reasons, or gameplay reasons, allowing normal rods to maintain the interaction of simply pulling the entity.
Reeling has only 1 level and adds the following interactions on pulling in the entity type:

• Pull the chest from chest boats, emptying the items on to the ground
• Pull the associated block type from minecart variants
• Steal armor from armored wolves
• Steal a snow golems carved pumpkin
• Steal a sheep's wool right off their skin
• Steal a mooshroom's mushrooms, turning them into cows
• Steal honeycomb from a bee carrying nectar, making it angry at you
• Steal a horse's armor and saddle
• Steal saddles from mobs that can wear saddles
• Steal chests from ChestedHorses, emptying the items on to the ground
• Steal carpets from llamas' backs
• Steal armor from mobs that can wear armor from survival means
• Steal held items from mobs that can hold items in hands *
  • Stealing a held item from a villager sells out that trade and gives the player a 20 major negative reputation
  • Stealing a trident from a drowned will roll a random chance with a 11.5% chance of success (unless the mainhand drop chance is not default) this is the same chance as using looting 3. If the chance fails, the trident will break.
• Steal a happy ghast's harness

Barbed

Barbed is an enchantment that revolves around dealing damage, turning a fishing rod into a lethal weapon. It has 5 levels.
Barbed applies an initial scratching damage to the hooked mob on pulling and then bleeding damage over time.
The level scales both the scratching damage, and the frequency of bleeding damage.
Damage over time lasts 3 seconds, regardless of enchantment level.

Notes

• Stealing equipment with Reeling
  • Might want to investigate Add Opt-In Logging to Modules Usable as Griefing Tools #1037 for player theft moderation
  • Currently it is unable to steal pillager captain flags. This is because pillager types are set to steal only hand items, as they can't wear armor by survival means (other than the flag).
• Enchantment Balancing
  • Could be exclusive to mending or unbreaking if it is deemed necessary for balance

To-Do:

• Investigate notes above
• Icon, Promo, Readme
• Guidebook

[Bloo-dev]

Reeling and Barbed are now mutually exclusive

[runcows]

Added drop chance usage to reeling, including an entity type tag for entities that should ignore drop chances.
When the drop chance fails, the equipment item in question just breaks.

Currently, the default drop chance is set to 8.5%, matching vanilla's base drop chance without looting.
Personally, I believe it should be more powerful than that, but I'm setting it here as a start to see what others think.

[Bloo-dev]

Added drop chance usage to reeling, including an entity type tag for entities that should ignore drop chances. When the drop chance fails, the equipment item in question just breaks.

Currently, the default drop chance is set to 8.5%, matching vanilla's base drop chance without looting. Personally, I believe it should be more powerful than that, but I'm setting it here as a start to see what others think.

Seeing that the player has to put in some effort to get this enchant, I think for armor and tools on most entities reeling success should be almost guaranteed; with the drop chance mode being the exception for things like tridents on drowned.

[runcows]

Seeing that the player has to put in some effort to get this enchant, I think for armor and tools on most entities reeling success should be almost guaranteed; with the drop chance mode being the exception for things like tridents on drowned.

Revisiting this after a few days, I definitely agree.
How does this sound then?

• If a slot has a 0% drop chance, it should fail.
  • There are exceptions to that, where the 0% should be ignored (villager and vex mainhand)
• If a slot has a non-zero drop chance, drop should be guaranteed.
  • There are exceptions to that, where a chance is checked (trident drowned)

Remaining Questions

• Are there any other chances that should be checked, other than tridents on drowned?
• Is 8.5% a good drop chance for tridents off of drowned? It matches non-looting chances, but we can easily configure it to have a higher chance.
• For a 0% drop chance, is the fail behaviour breaking the slot or should it just not do anything?

[Bloo-dev]

* If a slot has a 0% drop chance, it should fail.
  
  * There are exceptions to that, where the 0% should be ignored (villager and vex mainhand)

* If a slot has a non-zero drop chance, drop should be guaranteed.
  
  * There are exceptions to that, where a chance is checked (trident drowned)

Agreed.

Remaining Questions

* Are there any other chances that should be checked, other than tridents on drowned?

* Is 8.5% a good drop chance for tridents off of drowned? It matches non-looting chances, but we can easily configure it to have a higher chance.

* For a 0% drop chance, is the fail behaviour breaking the slot or should it just not do anything?

• I can't think of any right now.
• 8.5% sounds good to me. I wouldn't be opposed to making it the looting III chance. When a chanced reel fails, it should break the equipment it was trying to reel.
• 0% drop chance equipment should just be ignored. You could play a sound akin to the hook "slipping off" the piece.

[runcows]

Implemented the drop chance rework as discussed above.

• Currently drowned holding tridents are the only thing that will roll the random chance. Unless the drop chance is changed by something else, it will default to 11.5%, which is the same as looting 3.
• 0% drop chance now plays a sound when fails instead of breaking the item

Also updated the module to work with 1.21.6