-
Notifications
You must be signed in to change notification settings - Fork 4
JSR readiness #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
JSR readiness #165
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: publish | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| # using npx to avoid needing to install deno | ||
|
|
||
| # --dry-run is used to avoid publishing the | ||
| # module until we can figure out how to handle | ||
| # the jsr.io publishing with the @gamebridge account admin. | ||
|
|
||
| # When we decide to publish to JSR we'll need to rename the | ||
| # module to @gamebridge/serialize or something similar | ||
| # because `_` is not allowed in module names. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, that's interesting.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeaa! Man it was a gut punch to hear that |
||
| - run: npx jsr publish --dry-run | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,53 +1,33 @@ | ||
| { | ||
| "name": "@gamebridge/ts_serialize", | ||
| "version": "v2.1.0", | ||
| "exports": { | ||
| ".": "./mod.ts" | ||
| }, | ||
| "imports": { | ||
| "@deno/dnt": "jsr:@deno/dnt@^0.42.1", | ||
| "@std/assert": "jsr:@std/assert@^1.0.13", | ||
| "@std/cli": "jsr:@std/cli@^1.0.17" | ||
| "@std/assert": "jsr:@std/assert@^1.0/assert", | ||
| "@std/assert/equals": "jsr:@std/assert@^1.0/equals", | ||
| "@std/assert/assertStrictEquals": "jsr:@std/assert@^1.0/strict-equals", | ||
| "@std/assert/assertNotEquals": "jsr:@std/assert@^1.0/not-equals", | ||
| "@std/assert/fail": "jsr:@std/assert@^1.0/fail" | ||
| }, | ||
| "lock": false, | ||
| "compilerOptions": { | ||
| "experimentalDecorators": true | ||
| }, | ||
| "fmt": { | ||
| "include": ["./"], | ||
| "exclude": ["./dist"] | ||
| }, | ||
| "test": { | ||
| "include": ["./"], | ||
| "exclude": ["./dist"] | ||
| }, | ||
| "lint": { | ||
| "include": ["./"], | ||
| "exclude": ["./dist"] | ||
| }, | ||
| "typeCheck": { | ||
| "include": ["./"], | ||
| "exclude": ["./dist"] | ||
| "publish": { | ||
| "exclude": [ | ||
| ".github", | ||
| ".vim", | ||
| ".vscode", | ||
| "coverage", | ||
| ".editorconfig", | ||
| "**/*.test.ts" | ||
| ] | ||
| }, | ||
| "tasks": { | ||
| "build": { | ||
| "description": "Build the project for npm, pass in your flags to override the defaults", | ||
| "command": "./_build_npm.ts -v v0.0.0-test -e ./mod.ts -o ./dist" | ||
| }, | ||
| "lint": { | ||
| "description": "Run linting", | ||
| "command": "deno lint" | ||
| }, | ||
| "fmt": { | ||
| "description": "Run formatting", | ||
| "command": "deno fmt" | ||
| }, | ||
| "test": { | ||
| "description": "Run tests", | ||
| "command": "deno test --doc" | ||
| }, | ||
| "test:coverage": { | ||
| "description": "Run tests with coverage", | ||
| "command": "deno test --coverage=coverage --doc" | ||
| }, | ||
| "test:coverage:report": { | ||
| "description": "Generate coverage report", | ||
| "command": "deno coverage --lcov coverage > coverage/lcov.info" | ||
| } | ||
| "test": "deno test --doc --parallel", | ||
| "test:coverage": "deno test --doc --parallel --coverage=./coverage", | ||
| "test:coverage:report": "deno coverage --lcov ./coverage > ./coverage/lcov.info" | ||
| }, | ||
| "compilerOptions": { | ||
| "experimentalDecorators": true | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we publish to both jsr and npm? Is that a typical thing to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is pretty normal to publish to both. NPM adoption is important, and JSR is described as a superset of NPM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although in my eagerness, I removed NPM publish, I can easily put it back