Add Block / Item ID conversion and add support for larger ids / data in schematic files #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://github.com/spacebuilder2020/worldedit-gtnh/blob/master/src/main/java/com/sk89q/worldedit/forge/ForgeWorldEdit.java#L125 long term fix: update data to be of type short instead of byte
…. (to maintain compat with vanilla)
This was referenced Feb 15, 2025
|
Initially, I wanted to preserve the ability to set a block to -1, so I did not do any unsigned casting on the second byte of the data block. However, looking at this code, it seems -1 is for wild card and that doesn't seem like a feature that you would expect to get from a schematic since that is a snapshot of a world region so I am thinking it may be best to change the code to do an unsigned cast to int on the data short. Thoughts? Update: After more testing, determined that there were blocks that were being set to -1 erroneously, and since -1 was for wild cards and caused the copy to stop when pasting in, I have since updated logic to always do a unsigned cast. |
…t is only applicable for wildcards and causes the paste to fail.
Replace calls to toUnsignedInt with bitwise equivalent for consistency with rest of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.