Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Localization #36

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Add Localization #36

merged 2 commits into from
Jan 2, 2025

Conversation

glowredman
Copy link
Member

This adds some missing localizations for unlocalized names returned by the ItemStack-insensitive version of Item.getUnlocalizedName().
Relevant for the Item/Block stats introduced in GTNewHorizons/Hodgepodge#398.

@glowredman glowredman requested a review from a team January 2, 2025 01:23
Glease
Glease approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Glease Glease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so fake blocks would show up in stat anyway? well that's not very useful. regardless, this can be merged

@Glease Glease merged commit bf5dd55 into master Jan 2, 2025
1 check passed
@Glease Glease deleted the glowredman-patch-1 branch January 2, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glease Glease Glease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glowredman @Glease