Added the option to set fsname manually

[lowBudgetHypothermia]

This was done to allow the copytool to archive to the same fs (TSM) from different lustre instances.

[ChristianTackeGSI]

Why no_argument?

Why not required_argument (like with --conf)?

[lowBudgetHypothermia]

I thought the default should be that if no flag is given it defaults to assigning it to whatever mount is.

[ChristianTackeGSI]

man getopt_long:

has_arg
       is:  no_argument (or 0) if the option does not take an argument;
       required_argument (or 1) if the option requires an argument;  or
       optional_argument  (or  2) if the option takes an optional argu‐
       ment.

Reading that, I am surprised, that it works at all…

There are two questions:

1. Is the option (including argument to the option) optional or required?
2. IF one gives the option, is the argument optional, required (or ignored)?

I guess, you want (1) optional (2) required.

[ChristianTackeGSI]

I think optional_argument means that you can give --fsname without any arguments. That does not feel right to me?

[ChristianTackeGSI]

Please consider using braces, even for single line commands:

	if (!opt.o_fsname[0]) {
        strncpy(opt.o_fsname, opt.o_mnt, DSM_MAX_FSNAME_LENGTH);
    }

[lowBudgetHypothermia]

The braces were left out to stay somewhat congruent with another condition check 2 lines below it. Do you want me to change them both?

if (len_fsname > 2 && opt.o_fsname[len_fsname - 1] == '/')
		opt.o_fsname[len_fsname - 1] = '\0';

[ChristianTackeGSI]

Just give new code braces. :-)