Invite expiration fix #1534
Merged
Invite expiration fix #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrazoon
reviewed
Jan 16, 2025
terrazoon
reviewed
Jan 16, 2025
terrazoon
approved these changes
Jan 16, 2025
ccostino
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Thanks, @A-Shumway42! I agree with @terrazoon about the print statements. Let's convert them to proper logging statements if they're providing useful visibility/information into what's happening, or remove them. Thanks!
added 2 commits
January 16, 2025 08:59
…invite-expiration-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
There have been instances where SQLAlchemy does some funky magic and sets the created_at times prior. We think this could be the issue with invites expiring mysteriously. The invite path leads through here so we add some debugging logic and update the created_at stamp if necessary.
Added some error handling because persist notification is called in quite a bit of different paths, so the created_at value is passed through in different forms. This fixed the issues I was having with tests being broken.
*During local testing, I have not been able to reproduce an invite expiring. Invites didn't expire on staging either.