make sure we reuse boto3 clients and resources #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrazoon
force-pushed
the
notify-api-1526
branch
from
dde51fb to
5cedd64
Compare
terrazoon
changed the title
ccostino
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Thanks, @terrazoon! I took a look here and flagged a couple of things, and left a general comment/discussion question about the use of a global vs. just moving things into a class instead. We don't need to dig in deeply on that but I did want to call it out.
Thanks for all of the tests here, too! 🎉
added 2 commits
January 15, 2025 07:40
ccostino
approved these changes
Jan 15, 2025
xlorepdarkhelm
approved these changes
Jan 15, 2025
A-Shumway42
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
boto3 clients and resources are thread safe and have built in connection pooling, so we should reuse them as much as possible. Implement the singleton pattern to make sure we are doing so.
Security Considerations
N/A