add pending stats to daily stats endpoint #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
temporarily deployed
to
staging
GitHub Actions
Inactive
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
temporarily deployed
to
staging
GitHub Actions
Inactive
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
temporarily deployed
to
staging
GitHub Actions
Inactive
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
temporarily deployed
to
staging
GitHub Actions
Inactive
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
temporarily deployed
to
staging
GitHub Actions
Inactive
ccostino
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Thank you, @heyitsmebev, this looks great!
I called out a couple of things that I wanted to make sure we double check as we've been bitten in those spots in the past, but I think they're right as is. Asking for @xlorepdarkhelm and @terrazoon's help there to confirm!
ccostino
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Thanks again @heyitsmebev and @xlorepdarkhelm!
We walked through the open questions as a team and resolved any lingering questions, thanks to everyone else for participating!
terrazoon
approved these changes
Jan 28, 2025
heyitsmebev
deleted the
2199-add-pending-message-data-to-daily-and-user_daily-stats
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endpoints to update:
get_service_notification_statistics_by_day
get_user_service_notification_statistics_by_day
The purpose of this ticket is to update the dashboard UI to display the number of pending statuses, similar to the job page, where delivery statuses for pending, delivered, and failed messages are shown.
These numbers should align with those provided by AWS and remain consistent between job statuses and notification statuses.
UI dashboard
Delivery status
