Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further work on phone number validation #1332

Merged
merged 1 commit into from
Sep 18, 2024
Merged

further work on phone number validation #1332

merged 1 commit into from
Sep 18, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Sep 13, 2024

Description

  1. checking if the phone number was in SIMULATED_SMS_NUMBERS failed, because recipient is not stored with a + sign, but SIMULATED_SMS_NUMBERS has plus signs. Fix that.
  2. add more debug statements so we know more easily if it worked or not.
  3. Remove an unrelated debug statement in s3.py that got checked in somehow. It is harmless in terms of PII but leads to huge amounts of logging.

Currently this can only be tested on staging, as only staging (theoretically) has pinpoint permissions. Testing on local will give an 'access denied'.

Security Considerations

N/A

@terrazoon terrazoon changed the title some cleanup further work on phone number validation Sep 13, 2024
@terrazoon terrazoon self-assigned this Sep 13, 2024
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ccostino ccostino merged commit 5db03fe into main Sep 18, 2024
7 checks passed
@ccostino ccostino deleted the notify-api-1306 branch September 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants