Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsiveness of RGA GUI disassembly view #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1,194 −1,235
Open

Fix responsiveness of RGA GUI disassembly view #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions RadeonGPUAnalyzerGUI/Include/Qt/rgIsaDisassemblyView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,6 @@ protected slots:
// Set the cursor to pointing hand cursor for various widgets.
void SetCursor();

// Set the border stylesheet.
virtual void SetBorderStylesheet() = 0;

// Set the current target GPU to display disassembly for.
void SetTargetGpu(const std::string& targetGpu);

Expand Down
3 changes: 0 additions & 3 deletions RadeonGPUAnalyzerGUI/Include/Qt/rgIsaDisassemblyViewOpenCL.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ class rgIsaDisassemblyViewOpenCL : public rgIsaDisassemblyView
virtual bool PopulateBuildOutput(const std::shared_ptr<rgProjectClone> pProjectClone, const rgBuildOutputsMap& buildOutputs) override;

protected:
// Set the border stylesheet.
virtual void SetBorderStylesheet() override;

// Populate the disassembly view with the given CLI build output.
bool PopulateDisassemblyView(const std::vector<rgSourceFileInfo>& sourceFiles, const rgBuildOutputsMap& buildOutput);
};
4 changes: 0 additions & 4 deletions RadeonGPUAnalyzerGUI/Include/Qt/rgIsaDisassemblyViewVulkan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,4 @@ class rgIsaDisassemblyViewVulkan : public rgIsaDisassemblyViewGraphics
public:
rgIsaDisassemblyViewVulkan(QWidget* pParent);
virtual ~rgIsaDisassemblyViewVulkan() = default;

protected:
// Set the border stylesheet.
virtual void SetBorderStylesheet() override;
};
5 changes: 0 additions & 5 deletions RadeonGPUAnalyzerGUI/Include/rgStringConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,11 +526,6 @@ static const char* STR_MAIN_WINDOW_STYLESHEET_FILE = "rgMainWindowStyle.q
static const char* STR_MAIN_WINDOW_STYLESHEET_FILE_OPENCL = "OpenCL/rgMainWindowStyleOpenCL.qss";
static const char* STR_MAIN_WINDOW_STYLESHEET_FILE_VULKAN = "Vulkan/rgMainWindowStyleVulkan.qss";

// Disassembly view frame border color.
static const char* STR_DISASSEMBLY_FRAME_BORDER_RED_STYLESHEET = "QFrame#frame {border: 1px solid rgb(224,30,55)}";
static const char* STR_DISASSEMBLY_FRAME_BORDER_GREEN_STYLESHEET = "QFrame#frame {border: 1px solid rgb(18, 152, 0)}";
static const char* STR_DISASSEMBLY_FRAME_BORDER_BLACK_STYLESHEET = "QFrame#frame {border: 1px solid black}";

// The "current" property of file menu items.
static const char* STR_FILE_MENU_PROPERTY_CURRENT = "current";

Expand Down
Loading