possible naive RCAS negative output fix #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurbeco
force-pushed
the
main
branch
3 times, most recently
from
beeb9fd to
c6efa6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional multiplier in this fix is needed to account for the difference between e (central sample) and minRingSample if (e << minRingSample) here:
// 0 == (w*(b+d+f+h)+e)/(4*w+1) -> w = -e/(b+d+f+h)
due to min max usage instead of individual taps we have:
e/(b+d+f+h) > e/(4maxRing) which is safe
But
e/(4maxRing) < minRing / (4*maxRing) in (e << minRingSample) case
So we risk getting such w that result output would be < 0