Skip to content

Add fix to handle aircraft bias convertion #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

rtodling
Copy link
Contributor

@rtodling rtodling commented May 6, 2025

Description

This provides a correction for converting aircraft biases. The convert stopped working after we split aircraft into temperature and wind.

Dependencies

none

Impact

allows for convert to work.

@rtodling rtodling requested a review from mranst May 6, 2025 21:49
@Dooruk
Copy link
Collaborator

Dooruk commented May 7, 2025

FYI @imoradi

@Dooruk
Copy link
Collaborator

Dooruk commented May 12, 2025

@rtodling this requires a simple pycodestyle fix

@imoradi
Copy link

imoradi commented May 13, 2025

Thank you for trying to fix this, but there seems to be still an issue with aircraft files.

@rtodling
Copy link
Contributor Author

Thank you for trying to fix this, but there seems to be still an issue with aircraft files.

@imoradi what issue? I have have no issues - I've ran this for multiple cases and different periods ... can you be specific?

@imoradi
Copy link

imoradi commented May 22, 2025

That is what we discussed last time we chatted on Teams. The problem is resolved if we remove the missing obs diags from Yaml file. So I was able to run it. Thanks

@Dooruk
Copy link
Collaborator

Dooruk commented May 23, 2025

@rtodling this needs pycodestyle fixes

Copy link
Collaborator

@mranst mranst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 FYI @Dooruk

@Dooruk Dooruk merged commit f920b47 into develop May 23, 2025
2 checks passed
@Dooruk Dooruk deleted the bugfix/rtodling/convert_ncdiags_acftbias branch May 23, 2025 19:48
@rtodling rtodling mentioned this pull request May 23, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants