Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename tile_coord%pfaf to tile_coord%pfaf_index; add matlab reader for tile file (ASCII and nc4) #78

Merged
merged 11 commits into from
Feb 22, 2025

Conversation

gmao-rreichle
Copy link
Collaborator

@gmao-rreichle gmao-rreichle commented Jan 26, 2025

GEOS-ESM/GEOSgcm_GridComp#1028 adds an nc4 version of the tile file in make_bcs (GEOSgcm_GridComp). The present PR clarifies the ambiguously named field "pfaf" of the GEOSldas tilecoord structure to "pfaf_index".

The present PR also adds a matlab reader for the tile file (ASCII and nc4). The ASCII reader works for both EASE and cube-sphere tile files and helps document the contents of the tile file, which depend on EASE vs. cube-sphere and tile type.

@gmao-rreichle gmao-rreichle added documentation Improvements or additions to documentation enhancement New feature or request 0-diff post-processing labels Jan 26, 2025
@gmao-rreichle gmao-rreichle self-assigned this Jan 26, 2025
@gmao-rreichle
Copy link
Collaborator Author

Successfully 0-diff tested after d7a9a75

@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 22, 2025 16:45
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner February 22, 2025 16:45
@gmao-rreichle gmao-rreichle merged commit f2635ee into develop Feb 22, 2025
9 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/rreichle/rename_pfaf branch February 22, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff documentation Improvements or additions to documentation enhancement New feature or request post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants