Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display notes page #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rupalisingh
Copy link

@rupalisingh rupalisingh commented Oct 16, 2021

Hi @sandra9711 ,

I have made the Display Notes page according to the given design. Let me know if there is any changes or something else is to be added.

Also, I am participating in Hacktoberfest so I request you to please add 'Hacktoberfest-accepted' label to this pull request so that it counts.

Thank you

@sandra9711
Copy link
Collaborator

Hi @sandra9711 ,

I have made the Display Notes page according to the given design. Let me know if there is any changes or something else is to be added.

Also, I am participating in Hacktoberfest so I request you to please add 'Hacktoberfest-accepted' label to this pull request so that it counts.

Thank you

Hi @rupalisingh
A separate page is not needed to display notes. You can keep it as a component itself and it has to be used in pages for each branch. Pages required are already created, like src->Pages->CS->cs.
The flow of the site is given in the README. You can also check that out here Prototype

@rupalisingh
Copy link
Author

Hi @sandra9711,

I understand that the display notes component is required for all the subjects. But there is no Navbar and for subjects only page is created. I can add my displayNotes as a component in these pages. But I think there should be backend or a simple JSOn file to store all the information related to that subject and branch, so that I can pass them as props to my DisplayNotes Component.

@sandra9711
Copy link
Collaborator

Hi @sandra9711,

I understand that the display notes component is required for all the subjects. But there is no Navbar and for subjects only page is created. I can add my displayNotes as a component in these pages. But I think there should be backend or a simple JSOn file to store all the information related to that subject and branch, so that I can pass them as props to my DisplayNotes Component.

We are planning to embed a google form to take data on the submission page once it is completed. Since that page is yet to be completed you can use a CSV file to import and display data. Please let me know if you can create a CSV file for sample data. Data has to be arranged year-wise for each branch.

@rupalisingh
Copy link
Author

Hi @sandra9711,

Thank you for your patience, but I won't be available for few weeks as I am bit occupied. If you need these changes now, then please reassign it to somebody else, who will be able to give you this on time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants