[Feature] Picker, Toast 컴포넌트 페이지 마크업 #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamo-o
requested review from
eugene028,
SeieunYoo and
soulchicken
as code owners
|
|
Size Change: 0 B Total Size: 680 kB ℹ️ View Unchanged
|
SeieunYoo
approved these changes
Feb 5, 2025
Comment on lines
+29
to
+31
| <Card style={{ padding: "73px 429px" }}> | ||
| <Toast id="1" subText="Subtext" text="Text" /> | ||
| </Card> |
There was a problem hiding this comment.
p3;
해상도가 낮은 경우에는 이런 식으로 ui에 스크롤이 생길 거 같아요.
paddingTop, bottom 만 주는 건 어떨까요?
There was a problem hiding this comment.
p4;
구현적으로는 내부에서만 쓰고 있지만 디자인 시스템 소개 가이드 페이지이기에 디자인 스펙 으로 소개하는 건 괜찮을 거 같아요 !
svg 로 뽑아서 넣으면 좋을 거 같습니닷
Comment on lines
+18
to
+25
| const title = componentItems.find((item) => item.title === "Picker"); | ||
| return ( | ||
| <> | ||
| <Title | ||
| main={title?.title || ""} | ||
| sub={title?.description || ""} | ||
| variant="header" | ||
| /> |
There was a problem hiding this comment.
p5;
title 와 description 모두 담고 있는 변수라서 pageData 같은 포괄적인 의미를 담으면 좋을 거 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
디자인 시스템 문서의
Toast컴포넌트와Picker컴포넌트 페이지를 마크업합니다.🙏 여기는 꼭 봐주세요!
개발 스펙과 다른 부분은 우선 제외했습니다. (아래 두가지)
: 라이브러리 활용으로 스타일만 주입, 내부에서만 사용)
: 베리언트가 따로 없고 와클이랑 와디 디자인이 조금 달라서 개발 시 놓쳤던 부분이네요 ㅠ 확실하게 정리해서 리팩터링이 필요할 것 같습니닷