fix(web-ui): shortcut digit lookup, overrides, editor canvas inheritance#712
Merged
bobleer merged 1 commit intoMay 14, 2026
Conversation
- Match Digit/Numpad codes so Ctrl+digit bindings work across keyboard layouts - When focus is editor scope, also evaluate canvas shortcuts (tab switch, etc.) - Replace shallow merge for user overrides so cleared modifiers do not linger - Version stored keybindings and skip overrides for scene.openSession - Add ShortcutManager tests for macOS primary modifier and conflict checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Digit*/Numpad*codes so Ctrl+digit shortcuts resolve consistently across keyboard layouts.editorscope), also evaluatecanvasshortcuts so tab-switch and related bindings remain available.scene.openSession(non-customizable).Verification
pnpm run lint:web && pnpm run type-check:web && pnpm --dir src/web-ui run test:run