refactor(core): move tool registry contracts into agent-tools#708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-agent-tools.bitfun-coreregistry as product runtime assembly: builtin tool list,dyn Tooladapter, snapshot decoration, and legacy compatibility paths.ToolUseContextand concrete tool implementations stay core-owned until a reviewed port/provider design and equivalence tests exist.Guardrails
ToolUseContextmigration in this PR.Validation
node scripts/check-core-boundaries.mjsrustfmt --edition 2021 --check src\crates\agent-tools\src\framework.rs src\crates\agent-tools\src\lib.rs src\crates\agent-tools\tests\tool_contracts.rs src\crates\core\src\agentic\tools\framework.rs src\crates\core\src\agentic\tools\registry.rs src\crates\core\src\agentic\tools\restrictions.rs src\crates\core\src\agentic\tools\pipeline\tool_pipeline.rs src\crates\runtime-ports\src\lib.rsgit diff --check gcwing/main..HEADcargo test -p bitfun-agent-toolscargo test -p bitfun-runtime-portscargo test -p bitfun-core registry_ --libcargo test -p bitfun-core dynamic_tool_provider_ --libcargo check --workspace(passes with existingbitfun-cliunusedReadwarning)cargo test --workspace(passes with existingbitfun-cliunusedReadwarning)