Skip to content

Conversation

@Davidcode-png
Copy link
Contributor

[FEATURE]: Implement Create ACL Binding Rules endpoint

Description

This PR introduces support for managing ACL Binding Rules in Consul and the following changes were made:

  • Added BindingRuleEntry and BindingRuleResponse models.
  • Added BindingRule to the Client InitializeEndpoints () to expose the class.
  • Implemented the Create BindingRule method to handle the request PUT /v1/acl/binding-rule.
  • Created interface IBindingRuleEndpoint.
  • Added a test BindingRule_Create to validate changes.

Addresses #467

Related Issues

Additional Context

Checklist

Please make sure to check the following before submitting your pull request:

  • Did you read the contributing guidelines?
  • Did you update the docs?
  • Did you write any tests to validate this change?

{
var authMethodsResponse = await _client.AuthMethod.List();
var existingAuthMethod = authMethodsResponse.Response?.FirstOrDefault();
Skip.If(existingAuthMethod == null, "No auth methods available in Consul for testing");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Davidcode-png, can you try to figure out how to avoid skipping the test?

I tried running it locally, and the auth method is null, so the test didn't run. I suspect it doesn't run on the CI as well, so we actually don't know if the implementation works or not.
Can you figure out a change in the test configuration that would lead to actually running the test? Otherwise, we cannot accept this change as we don't know whether it works or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants