Merged
Conversation
dosubot
bot
added
the
size:XS
whitead
approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PaperQA PyMuPDF integration to rely on PyMuPDF’s corrected typing for Page.find_tables, aligning the code with the upstream fix referenced in PyMuPDF issue #4932.
Changes:
- Bump PyMuPDF (dev extra) lower bound to
>=1.27.2.2to pick up thePage.find_tablestyping fix. - Switch table extraction to call
page.find_tables()directly (instead ofpymupdf.table.find_tables(page)). - Refresh
uv.lockto reflect the new PyMuPDF version and dev-extra constraint.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Updates resolved PyMuPDF version to 1.27.2.2 and records the dev-extra constraint for the typing fix. |
packages/paper-qa-pymupdf/src/paperqa_pymupdf/reader.py |
Uses Page.find_tables() for table detection, matching the API whose typing was fixed upstream. |
packages/paper-qa-pymupdf/pyproject.toml |
Adds a dev extra constraint PyMuPDF>=1.27.2.2 to ensure developers/tests get the corrected typing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyMuPDF fixed the typing on
Page.find_tablesin pymupdf/PyMuPDF#4932