feat: Volume independent analyzer on web #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACrazyTown
added a commit
to ACrazyTown/Funkin
that referenced
this pull request
Apr 5, 2025
ACrazyTown
added a commit
to ACrazyTown/Funkin
that referenced
this pull request
Apr 5, 2025
charlesisfeline
pushed a commit
to charlesmilkjug/Funkin2
that referenced
this pull request
Apr 5, 2025
ACrazyTown
added a commit
to ACrazyTown/Funkin
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make the analyser volume-independent on web for parity across desktop and web.
compressed.mp4
Instead of attaching the
AnalyserNodedirectly to the howler gain node, we can check if there's a buffer source node available. If it is, we can "hijack" it and attach our analyser to it directly, allowing us to get audio data straight from the source without any volume changes. If the buffer source node isn't available, we can simply fallback to the old method and attach the analyser to the gain node.I'm not sure how safe it is to mess with the nodes like this but from my brief testing I haven't encountered any issues. One quirk of this is that now analysers have to be cleaned up with
analyser.cleanup()otherwise there might be duplicate event listeners on the sound which may break things. (will be resolved in Funkin' with FunkinCrew/Funkin#4579)