Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant syntax typos and unused imports #4092

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Removed redundant syntax typos and unused imports #4092

wants to merge 13 commits into from

Conversation

Starexify
Copy link

Does this PR close any issues? If so, link them below.

Fixes for #4083

Briefly describe the issue(s) fixed.

Just removing some syntax typos and imports which shouldn't exist, nothing much
(everything is provided in the Issue)

@Starexify Starexify mentioned this pull request Feb 3, 2025
Open
3 tasks
@Hundrec Hundrec added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. type: enhancement Involves an enhancement or new feature. pr: haxe PR modifies game code. and removed Haxe type: enhancement Involves an enhancement or new feature. labels Feb 3, 2025
@github-actions github-actions bot added large and removed large labels Feb 3, 2025
@github-actions github-actions bot added the large label Feb 3, 2025
@Hundrec Hundrec added the type: chore Involves minor adjustments that do not make functional changes. label Feb 4, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 4, 2025 •
edited
Loading

I think the github-actions bot is on some funky stuff
Screenshot 2025-02-04 185811
Screenshot 2025-02-04 185952

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 4, 2025

You should change the title of this PR to involve "a lot of imports" or something like that

@Starexify Starexify changed the title Removed redundant syntax typos Removed redundant syntax typos and unused imports Feb 4, 2025
@Starexify Starexify deleted the branch FunkinCrew:develop February 4, 2025 10:40
@Starexify Starexify closed this Feb 4, 2025
@Starexify Starexify deleted the develop branch February 4, 2025 10:40
@Starexify Starexify restored the develop branch February 4, 2025 10:41
@Lasercar
Copy link
Contributor

Lasercar commented Feb 4, 2025

Huh? What happened?

@Starexify
Copy link
Author

Starexify commented Feb 4, 2025 •
edited
Loading

Huh? What happened?

I deleted my fork's develop branch by mistake when deleting the other useless branches so I can import the Repo faster

@Starexify Starexify reopened this Feb 4, 2025
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Feb 4, 2025
@Starexify
Copy link
Author

Could I also update the deprecated methods in this PR ?

@Lasercar
Copy link
Contributor

Lasercar commented Feb 8, 2025 •
edited
Loading

Could I also update the deprecated methods in this PR ?

I'd make that a separate PR and branch, as it's not the focus of this one. plus, you get to pad your stats (/j)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Starexify @Lasercar @Hundrec @AbnormalPoof