Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] EVEN MORE ReflectUtil additions. #4019

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[ENHANCEMENT] EVEN MORE ReflectUtil additions. #4019

merged 1 commit into from
Jan 23, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

This PR adds the remaining missing functions to ReflectUtil. This should hopefully complete the class and give scripts access to every function in Reflect that isn't harmful or malicious.

@github-actions github-actions bot added pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. labels Jan 22, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. topic: mods Related to the creation or use of mods. labels Jan 22, 2025
@EliteMasterEric EliteMasterEric self-assigned this Jan 22, 2025
@AbnormalPoof AbnormalPoof added the status: pending triage Awaiting review. label Jan 22, 2025
@EliteMasterEric EliteMasterEric merged commit 6216655 into FunkinCrew:develop Jan 23, 2025
5 checks passed
@EliteMasterEric EliteMasterEric added this to the 0.6.0 milestone Jan 23, 2025
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Jan 23, 2025
@EliteMasterEric
Copy link
Member

A change I added onto this internally; Reflect and Type are no longer blacklisted! I instead aliased them to ReflectUtil, and added a couple error messages for when you try to call specific blacklisted functions.

@AbnormalPoof AbnormalPoof deleted the feat/waiter!!!-more-reflectutil-functions-please branch January 23, 2025 23:07
MidyGamy pushed a commit to MidyGamy/Funkin that referenced this pull request Jan 27, 2025
@AbnormalPoof @MidyGamy
Add 6 more functions to ReflectUtil (FunkinCrew#4019)
df60f7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
2 participants
@AbnormalPoof @EliteMasterEric