Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UI Controls Order #3027

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Change UI Controls Order #3027

merged 1 commit into from
Jan 23, 2025

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Jul 14, 2024

Linked Issues

Closes #3026

Changes

  • Reordered UI Controls from UP, LEFT, RIGHT, DOWN to LEFT, DOWN, UP, RIGHT,

Before

screenshot-2024-07-14-14-22-23

After

screenshot-2024-07-14-14-26-23

@lemz1 lemz1 changed the base branch from main to develop July 14, 2024 12:30
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jul 17, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Oct 3, 2024

I would love to have this QoL feature for 0.5.2

@ninjamuffin99 ninjamuffin99 force-pushed the develop branch 2 times, most recently from e0b1b01 to 410cfe9 Compare October 4, 2024 01:25
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. and removed size: small A small pull request with 10 or fewer changes. labels Oct 8, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Oct 16, 2024

Can we squash this into one commit and merge it? Would be a great minor QoL improvement for 0.5.3

@github-actions github-actions bot added size: large A large pull request with more than 100 changes. pr: documentation PR modifies documentation or README files. and removed size: large A large pull request with more than 100 changes. size: small A small pull request with 10 or fewer changes. labels Oct 16, 2024
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. size: medium A medium pull request with 100 or fewer changes. labels Oct 16, 2024
@lemz1 lemz1 force-pushed the reorder-controls branch 2 times, most recently from 79c7e5b to d3cdf09 Compare October 21, 2024 18:10
@lemz1
change ui controls order
048dd1f 
a lot of squashed stuff
@Hundrec Hundrec removed the pr: documentation PR modifies documentation or README files. label Jan 22, 2025
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
@EliteMasterEric
Copy link
Member

I just asked Dave and he says this is good 👍

@EliteMasterEric EliteMasterEric merged commit a01bcc3 into FunkinCrew:develop Jan 23, 2025
4 checks passed
@EliteMasterEric EliteMasterEric added this to the 0.6.0 milestone Jan 23, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Jan 23, 2025

Woo!

@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Jan 23, 2025
@MrBossGuy36
Copy link

great!

@Hundrec Hundrec added the topic: polish Involves minor polish to the UI or gameplay. label Jan 23, 2025
MidyGamy pushed a commit to MidyGamy/Funkin that referenced this pull request Jan 27, 2025
@lemz1 @MidyGamy
change ui controls order (FunkinCrew#3027)
e85a4af 
a lot of squashed stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hundrec Hundrec Hundrec approved these changes

@JVNpixels JVNpixels JVNpixels approved these changes

@tposejank tposejank tposejank approved these changes

@anysad anysad anysad approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: polish Involves minor polish to the UI or gameplay. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.

Enhancement: Reorder the Control Options
7 participants
@lemz1 @Hundrec @EliteMasterEric @MrBossGuy36 @anysad @tposejank @JVNpixels