fix(pynini cython): Allow pynini to be built #902
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft, as its only an install at the moment. Need to run it, and see if this works out (roughly. |
Right now, Pynini fails with the error "Cython cannot be found". More information is available in the following issue: * kylebgorman/pynini#30 This in turn, is used in the WeTextProcessing processing library. That library had a version bump, with the most recent version using an updated pynini library. This commit uses that version. It is not clear whether ther are any other API breaking changes; the diff between v2.1.5 and 2.1.6 in pynini is big, but looks to be mostly docs and similar.
|
only chang wetextprocessing version? do we need to change conda install pynini version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Pynini fails with the error "Cython cannot be found". More information is available in the following issue:
This in turn, is used in the WeTextProcessing processing library. That library had a version bump, with the most recent version using an updated pynini library.
This commit uses that version. It is not clear whether ther are any other API breaking changes; the diff between v2.1.5 and 2.1.6 in pynini is big, but looks to be mostly docs and similar.