Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): webpack 4, babel polyfill for async #77

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

glebec
Copy link
Member

@glebec glebec commented Feb 27, 2018

Assignee Tasks

  • added unit tests (or none needed)
  • written relevant docs (or none needed)
  • referenced any relevant issues (or none exist)

@tmkelly28
Copy link
Contributor

Is livereload hindering more than helping? If not, wouldn't it make more sense to leave it in until we actually do replace it?

@glebec
Copy link
Member Author

glebec commented Feb 27, 2018 via email

@tmkelly28
Copy link
Contributor

Ah, typical webpack. This looks fine to me then - merge away.

@khumphrey
Copy link
Contributor

I also think it looks good. And I like that you got rid of the bower bit too

@tmkelly28
Copy link
Contributor

Yeah, good riddance bower.

@glebec glebec merged commit b1c76f6 into master Feb 27, 2018
@glebec glebec deleted the f/upgrade-webpack-babel branch February 27, 2018 16:36
@glebec glebec mentioned this pull request Jan 30, 2019
EthanG19 pushed a commit to D3Doritos/AllSign that referenced this pull request Nov 26, 2019
…e-webpack-babel

feat(build): webpack 4, babel polyfill for async
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Webpack Enable async-await
3 participants