Implement host prefix cmds #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add the host prefix stuff to Apple II on my unified fuji device branch, all I had to do was add these 3 lines to iwmFuji: |
markjfisher
reviewed
Aug 18, 2025
| unsigned char hs; | ||
| } ghp; | ||
|
|
||
| memset(response,0,sizeof(response)); |
There was a problem hiding this comment.
this isn't required anymore, the values are immediately set
markjfisher
reviewed
Aug 18, 2025
| { | ||
| // Not implemented in A2 | ||
| return false; | ||
| // Not implemented in A2 |
markjfisher
reviewed
Aug 18, 2025
| bool is_success; | ||
| int bytes_read; | ||
|
|
||
| filename = malloc(256); |
There was a problem hiding this comment.
I've avoided using malloc in library. it pulls a huge chunk of cc65 into the application and is much better just using a static array.
markjfisher
reviewed
Aug 18, 2025
|
|
||
| pl_len = strlen(prefix) + 3 + 1; // add 1 for the null string terminator, although technically not required as we go by lengths | ||
|
|
||
| pl = malloc(pl_len); |
There was a problem hiding this comment.
ditto (just trying to tag them all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At @FozzTexx ask, implement get and set host prefixes for all current lib targets.
Apple still needs addit'l commands in firmware added for get host prefix.