Trigger new event to allow updating the response based on view data at one central place #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not easily possible to access the response object and the view at the same time. I have the use case, that I want to return a paginated list of data (using the KnpPaginationBundle) so I pass a pagination wrapper to the view layer.
The response has to contain some meta data (in fact I am using the
Linkheader similar to Githubs API), but I want to do this decoration at one central place and not in each controller. This is currently not possible. So I added a new event that is triggered in thecreateResponsemethod of theViewHandler.I think this addition could be useful for others, too. So I hope this gets merged.