Repository navigation
fix: escape impersonation banner email - #855
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
v-htmlsink infrontend/src/components/ImpersonationBanner.vuewith Vue text interpolation to ensure the impersonated user's email is escaped.frontend/src/components/ImpersonationBanner.spec.tsthat injects a malicious HTML payload as the email and asserts it is rendered as literal text and does not create DOM elements.Testing
npm run lintandnpm run tsc, which completed successfully for the frontend.npm run format, which passed for the frontend files updated.npm run test:run -- src/components/ImpersonationBanner.spec.ts, which passed (1 test, 1 passed).mise run lintcould not fully complete because the installedgolangci-lintwas built with Go 1.24 while the project targets Go 1.26.1, preventing the API lint step from finishing.mise run testcould not complete API integration tests because Testcontainers require Docker/rootless Docker, which is unavailable in the current environment.Codex Task