Fix class added to input group container in case of error

FriendsOfCake · Nov 30, 2024 · b935bd9 · b935bd9
1 parent 51e8ff3
commit b935bd9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/View/Helper/FormHelper.php b/src/View/Helper/FormHelper.php
@@ -510,7 +510,7 @@ public function control(string $fieldName, array $options = []): string
             isset($options['append']) ||
             isset($options['prepend'])
         ) {
-            $options['injectErrorClass'] = $this->_config['errorClass'];
+            $options['injectErrorClass'] = 'has-validation';
         }
 
         unset(

diff --git a/tests/TestCase/View/Helper/FormHelper/DefaultAlign/FileControlTest.php b/tests/TestCase/View/Helper/FormHelper/DefaultAlign/FileControlTest.php
@@ -478,7 +478,7 @@ public function testDefaultAlignFileControlInputGroupWithError()
                 ['label' => ['class' => 'form-label', 'for' => 'file']],
                     'File',
                 '/label',
-                ['div' => ['class' => 'input-group is-invalid']],
+                ['div' => ['class' => 'input-group has-validation']],
                     ['input' => [
                         'type' => 'file',
                         'name' => 'file',

diff --git a/tests/TestCase/View/Helper/FormHelper/HorizontalAlign/FileControlTest.php b/tests/TestCase/View/Helper/FormHelper/HorizontalAlign/FileControlTest.php
@@ -622,7 +622,7 @@ public function testHorizontalAlignFileControlInputGroupWithError()
                     'File',
                 '/label',
                 ['div' => ['class' => 'col-sm-7']],
-                    ['div' => ['class' => 'input-group is-invalid']],
+                    ['div' => ['class' => 'input-group has-validation']],
                         ['input' => [
                             'type' => 'file',
                             'name' => 'file',

diff --git a/tests/TestCase/View/Helper/FormHelper/InlineAlign/FileControlTest.php b/tests/TestCase/View/Helper/FormHelper/InlineAlign/FileControlTest.php
@@ -537,7 +537,7 @@ public function testInlineAlignFileControlInputGroupWithError()
                     ['label' => ['class' => 'form-label visually-hidden', 'for' => 'file']],
                         'File',
                     '/label',
-                    ['div' => ['class' => 'input-group is-invalid']],
+                    ['div' => ['class' => 'input-group has-validation']],
                         ['input' => [
                             'type' => 'file',
                             'name' => 'file',

diff --git a/tests/TestCase/View/Helper/FormHelperTest.php b/tests/TestCase/View/Helper/FormHelperTest.php
@@ -461,7 +461,7 @@ public function testAddOnWithError()
                 'label' => ['class' => 'form-label', 'for' => 'title'],
                     'Title',
                 '/label',
-                ['div' => ['class' => 'input-group is-invalid']],
+                ['div' => ['class' => 'input-group has-validation']],
                     'span' => ['class' => 'input-group-text'],
                         '@',
                     '/span',
@@ -487,7 +487,7 @@ public function testAddOnWithError()
                 'label' => ['class' => 'form-label', 'for' => 'title'],
                     'Title',
                 '/label',
-                ['div' => ['class' => 'input-group is-invalid']],
+                ['div' => ['class' => 'input-group has-validation']],
                     'input' => [
                         'type' => 'text',
                         'name' => 'title',