Skip to content

fix: video player playback rate #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasstorck wants to merge 2 commits into
base: development
Choose a base branch
from
+6 −3
Open

fix: video player playback rate #8407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb62ec3
fix: load video player with correct value for default playback rate
lukasstorck Dec 11, 2025
2cf4528
fix: set playback rate and default playback rate after initializing t…
lukasstorck Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2573,9 +2573,6 @@ export default defineComponent({
videoElement.muted = (muted === 'true')
}

videoElement.playbackRate = props.currentPlaybackRate
videoElement.defaultPlaybackRate = props.currentPlaybackRate

const localPlayer = new shaka.Player()

ui = new shaka.ui.Overlay(
Expand All @@ -2589,6 +2586,12 @@ export default defineComponent({
// otherwise it uses the browsers native captions which get displayed underneath the UI controls
await localPlayer.attach(videoElement)

// override values set by default after player is initialized
// localPlayer.attach(videoElement) seems to set the playback rate of videoElement to the
// provided default playback rate
videoElement.playbackRate = props.currentPlaybackRate
videoElement.defaultPlaybackRate = defaultPlaybackRate.value

// check if the component is already getting destroyed
// which is possible because this function runs asynchronously
if (!ui) {
Expand Down