smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion" #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion" Signed-off-by: Florian La Roche <[email protected]>
|
FYI: Similar small patches are submitted for FreeRTOS and FreeRTOS-Kernel. |
jasonpcarroll
previously approved these changes
Apr 28, 2025
|
Looks good to me - will get a second reviewer. Thank you! |
| @@ -958,7 +958,7 @@ enum smsc9220_error_t smsc9220_read_mac_address( const struct smsc9220_eth_dev_t | |||
| mac[ 0 ] = mac_low & 0xFF; | |||
| mac[ 1 ] = ( mac_low >> 8 ) & 0xFF; | |||
| mac[ 2 ] = ( mac_low >> 16 ) & 0xFF; | |||
There was a problem hiding this comment.
Any reason why the other mac indices are not typecasted to char.
There was a problem hiding this comment.
Maybe byte ordering issues on some architectures could make a difference?
best regards,
Florian La Roche
source/portable/NetworkInterface/MPS2_AN385/ether_lan9118/smsc9220_eth_drv.c
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion"
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.