-
Notifications
You must be signed in to change notification settings - Fork 181
smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion" #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion" Signed-off-by: Florian La Roche <[email protected]>
FYI: Similar small patches are submitted for FreeRTOS and FreeRTOS-Kernel. |
Looks good to me - will get a second reviewer. Thank you! |
@@ -958,7 +958,7 @@ enum smsc9220_error_t smsc9220_read_mac_address( const struct smsc9220_eth_dev_t | |||
mac[ 0 ] = mac_low & 0xFF; | |||
mac[ 1 ] = ( mac_low >> 8 ) & 0xFF; | |||
mac[ 2 ] = ( mac_low >> 16 ) & 0xFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why the other mac indices are not typecasted to char
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe byte ordering issues on some architectures could make a difference?
best regards,
Florian La Roche
smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion"
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.