-
Notifications
You must be signed in to change notification settings - Fork 30
Add support for building IfcOpenShell library #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added ifcopenshell dependency with specific commit for Windows ARM support.
for more information, see https://pre-commit.ci
|
The looks clean and correct to me. How can I help get this integrated? |
|
It isn't working for me (in a non-ARM x64 system). It just seems to sit there doing nothing after the "Building ifcopenshell" standard printout. This is very different from the others, since it's using a custom wrapper around the CMake calls, so it's taking me some time to get my head around what's going on. |
Hi @chennes |
|
I'm peeling back the onion now. The first problem is that: doesn't work as expected: the Second, when I run that script by hand, it tells me I have to be using PowerShell, which isn't how the automated system is configured, so that needs to be resolved somehow. And then, once I do am running in PowerShell, building the |
|
The first two problems were easy enough to resolve (and even resulted in an improved process -- I didn't know about the |
|
OK -- simply deleting the ifcopenshell clone and letting it re-run with the updated Visual Studio configuration script got me through the dependencies builds (though it's pretty awful that we have to rebuild so many dependencies - I assume that you tried to build IfcOpenShell with the already-built HDF5, OCCT, etc. and it didn't work?). Anyway, my IfcOpenShell CMake call is now failing with: |
|
And that problem anyway turned out to be related to how git submodules work (or fail to work, as the case may be). Next up... |
|
If I manually run each step on the command line it eventually works, and I can backtrack and run the script to get all the copying done, but I have yet to be able to get the script to run on its own from start to finish. |
|
I've incorporated these commits into a new PR that updates most of the rest of the LibPack as well, and takes some steps towards getting the IfcOpenShell build working in the context of the script. Still a work-in-progress, it doesn't run cleanly yet. #63 |
PR Description:
The PR adds support for building the IfcOpenShell library for both Windows x64 and Windows ARM64 as part of the FreeCAD LibPack compilation process.
The build_ifcopenshell function handles the building of dependencies, the IfcOpenShell Python extension, and installs IfcOpenShell into the FreeCAD LibPack installation directory.
The changes have been validated on both Windows x64 and Windows ARM64 platforms to ensure proper functionality of IfcOpenShell with FreeCAD