Skip to content

feat: adjust peer deps#628

Merged
zibs merged 4 commits intomainfrom
feat/adjust-peer-deps
Nov 6, 2025
Merged

feat: adjust peer deps#628
zibs merged 4 commits intomainfrom
feat/adjust-peer-deps

Conversation

@zibs
Copy link
Copy Markdown
Contributor

@zibs zibs commented Sep 9, 2025

Description

Adjusts skia peer dep

Fixes #627

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 9, 2025

🦋 Changeset detected

Latest commit: 6338124

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
victory-native-xl-docs Ready Ready Preview Comment Nov 5, 2025 11:17pm

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the peer dependency constraint for @shopify/react-native-skia to add an upper bound limit, preventing compatibility issues with future major versions. This change helps ensure version compatibility and addresses issue #627.

  • Added upper bound version constraint to @shopify/react-native-skia peer dependency
  • Created changeset documenting the dependency adjustment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/package.json Updates skia peer dependency to include upper version limit
.changeset/little-pigs-deliver.md Documents the peer dependency change for version tracking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zibs zibs marked this pull request as ready for review September 10, 2025 14:50
@zibs zibs requested a review from keithluchtel October 22, 2025 16:45
@zibs zibs merged commit 2a7cfb9 into main Nov 6, 2025
3 checks passed
@zibs zibs deleted the feat/adjust-peer-deps branch November 6, 2025 17:19
@github-actions github-actions bot mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update peer dependency to support Skia 2.x (Expo SDK 53)

4 participants